dsmiley commented on code in PR #4149:
URL: https://github.com/apache/solr/pull/4149#discussion_r2957019085
##########
solr/core/src/java/org/apache/solr/handler/admin/LukeRequestHandler.java:
##########
@@ -192,8 +238,346 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
info.add(
"NOTE",
"Document Frequency (df) is not updated when a document is marked for
deletion. df values include deleted documents.");
- rsp.add("info", info);
+ rsp.add(RSP_INFO, info);
+ rsp.setHttpCaching(false);
+ }
+
+ /** Per-field accumulation state across shards: aggregated response data and
field validation. */
+ private static class AggregatedFieldData {
+ final SimpleOrderedMap<Object> aggregated = new SimpleOrderedMap<>();
+ final String originalShardAddr;
+ final LukeResponse.FieldInfo originalFieldInfo;
+ private Object indexFlags;
+ private String indexFlagsShardAddr;
Review Comment:
If we're not sure it matters, let's not over-complicate this. Do the simple
thing ignore "live docs". We're not boxed in from realizing later we'd like
something more complicated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
