kotman12 commented on code in PR #4149:
URL: https://github.com/apache/solr/pull/4149#discussion_r2967444380
##########
solr/core/src/java/org/apache/solr/handler/admin/LukeRequestHandler.java:
##########
@@ -192,8 +238,346 @@ public void handleRequestBody(SolrQueryRequest req,
SolrQueryResponse rsp) throw
info.add(
"NOTE",
"Document Frequency (df) is not updated when a document is marked for
deletion. df values include deleted documents.");
- rsp.add("info", info);
+ rsp.add(RSP_INFO, info);
+ rsp.setHttpCaching(false);
+ }
+
+ /** Per-field accumulation state across shards: aggregated response data and
field validation. */
+ private static class AggregatedFieldData {
+ final SimpleOrderedMap<Object> aggregated = new SimpleOrderedMap<>();
+ final String originalShardAddr;
+ final LukeResponse.FieldInfo originalFieldInfo;
+ private Object indexFlags;
+ private String indexFlagsShardAddr;
Review Comment:
I did a little more testing on this and my initial theory that this
distinction only exists because we get the first *live* doc rather than the
first doc is _incorrect_. It turns out a fully deleted field will lack terms
even though it _does_ still have schema flags. If a field lacks terms then we
can't even get _any_ doc for it (live or not). A workaround for this would be
to ignore all fields that don't have terms (that _should_ have terms) but this
can get complicated for other reasons. As such, I am leaning toward keeping it
the way it is currently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
