epugh commented on PR #4222: URL: https://github.com/apache/solr/pull/4222#issuecomment-4094148579
> > ConfigSetAdminRequest.java: Has an inner static class List that shadows java.util.List, so used java.util.List.of(stream) with fully-qualified name > > this PR doesn't touch that file Yeah, this was a note that copilot highlighted, and I wanted to keep it to look into.. It turns out it makes sense it has a "List" named class.. I wasn't sure if there was soemthing in there to dig into it. At somepoint I want to go back and look at some of the places we are using "null" to see if they are the best way of doing things... I don't plan on making any changes to this PR more unless somethign comes up in review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
