cpoerschke commented on code in PR #4195:
URL: https://github.com/apache/solr/pull/4195#discussion_r2966943883
##########
solr/core/src/java/org/apache/solr/schema/ScalarQuantizedDenseVectorField.java:
##########
@@ -87,22 +90,17 @@ public void init(IndexSchema schema, Map<String, String>
args) {
if (ofNullable(args.remove(DYNAMIC_CONFIDENCE_INTERVAL_PARAM))
.map(Boolean::parseBoolean)
.orElse(false)) {
- this.confidenceInterval =
Lucene99ScalarQuantizedVectorsFormat.DYNAMIC_CONFIDENCE_INTERVAL;
+ this.confidenceInterval = 0f;
}
super.init(schema, args);
}
@Override
public KnnVectorsFormat buildKnnVectorsFormat() {
- return new Lucene99HnswScalarQuantizedVectorsFormat(
- getHnswM(),
- getHnswEfConstruction(),
- DEFAULT_NUM_MERGE_WORKER,
- getBits(),
- useCompression(),
- getConfidenceInterval(),
Review Comment:
Perhaps reduce visibility of the accessors and/or mark them deprecated.
```
- public boolean useCompression() {
+ @Deprecated
+ @VisibleForTesting
+ boolean useCompression() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
