dsmiley commented on code in PR #4195: URL: https://github.com/apache/solr/pull/4195#discussion_r2972795257
########## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc: ########## @@ -285,3 +285,15 @@ Attention: * The `llm` module has been renamed to `language-models`. * The HNSW parameters `hnswMaxConnections` and `hnswBeamWidth` have been renamed to `hnswM` and `hnswEfConstruction`, respectively, so they must be updated accordingly in the schema.xml file. + +== Solr 10.1 + +=== Lucene Codec Change + +Solr 10.1 upgrades the underlying Lucene library from 10.3 to 10.4, which introduces a new index codec (`Lucene104`). +New index segments will be written using the `Lucene104` codec format. +Existing segments written with older codecs (e.g. `Lucene103`) will continue to be readable. + +WARNING: After upgrading to Solr 10.1, downgrading to an earlier Solr 10.0.x version may fail because the older version does not include the `Lucene104` codec needed to read the newly written segments. +If you require the ability to roll back, back up your indexes before upgrading. +A full reindex would be needed to downgrade after new segments have been written in Solr 10.1. Review Comment: This sentence reads clearly yet I think it's message is confusing given what was said in the sentences before. For example, if we do backup-restore, why would a full reindex be needed? And you just said there may be errors for Solr 10 reading the indexes so, how would re-indexing (or any indexing or anything at all) work once you've seen such errors? You could drop this sentence entirely and I think we've already communicated what's needed. ########## solr/solr-ref-guide/modules/upgrade-notes/pages/major-changes-in-solr-10.adoc: ########## @@ -285,3 +285,15 @@ Attention: * The `llm` module has been renamed to `language-models`. * The HNSW parameters `hnswMaxConnections` and `hnswBeamWidth` have been renamed to `hnswM` and `hnswEfConstruction`, respectively, so they must be updated accordingly in the schema.xml file. + +== Solr 10.1 + +=== Lucene Codec Change + +Solr 10.1 upgrades the underlying Lucene library from 10.3 to 10.4, which introduces a new index codec (`Lucene104`). +New index segments will be written using the `Lucene104` codec format. +Existing segments written with older codecs (e.g. `Lucene103`) will continue to be readable. Review Comment: Suggest simpler: Older segments will continue to be readable. ########## solr/solr-ref-guide/modules/query-guide/pages/dense-vector-search.adoc: ########## @@ -319,7 +319,7 @@ The number of bits to use for each quantized dimension value Accepted values: 4 (half byte) or 7 (unsigned byte). `NOTE:` Existing Solr 10 schemas may still contain legacy scalar-quantization parameters such as -`confidenceInterval`, `dynamicConfidenceInterval`, or `compress`. They are accepted for backward +`confidenceInterval`, `dynamicConfidenceInterval`, or `compress`. They are deprecated (i.e. parsed and ignored but not used) for backward Review Comment: ignored implies not used. I suggest slightly simpler wording: > They are now deprecated and ignored. New schemas should ... You might even drop the "New schemas should..." sentence as it seems obvious (to me). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
