gerlowskija commented on code in PR #4229:
URL: https://github.com/apache/solr/pull/4229#discussion_r2981815316
##########
solr/core/src/java/org/apache/solr/schema/numericrange/AbstractNumericRangeField.java:
##########
@@ -82,9 +83,54 @@ public interface NumericRangeValue {
protected static final Pattern SINGLE_BOUND_PATTERN =
Pattern.compile("^" + COMMA_DELIMITED_NUMS + "$");
+ /**
+ * Regex fragment matching a comma-separated list of signed floating-point
numbers (integers or
+ * floating-point literals).
+ */
+ protected static final String COMMA_DELIMITED_FP_NUMS =
+ "-?\\d+(?:\\.\\d+)?(?:\\s*,\\s*-?\\d+(?:\\.\\d+)?)*";
+
+ private static final String FP_RANGE_PATTERN_STR =
Review Comment:
It was intentional, but I'm starting to second guess that decision now. My
assumption at the time was that our existing float and double fields (e.g.
DoublePointField) also didn't support scientific notation. There's no mention
of that in the ref-guide afaict at least.
But in testing it just now I can see that they do actually support it.
Thanks for raising this - will fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
