[ 
https://issues.apache.org/jira/browse/SOLR-18114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18068493#comment-18068493
 ] 

ASF subversion and git services commented on SOLR-18114:
--------------------------------------------------------

Commit 8299ae01ac2573f692290c3dd7a500c37fd62ebf in solr's branch 
refs/heads/branch_10x from Matthew Biscocho
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=8299ae01ac2 ]

[SOLR-18114] CloudSolrClient fails deleteById with directUpdatesToLeadersOnly 
but no route passed (#4219)

Fixed a bug where CloudSolrClient throws an exception when deleteById is sent a 
to collection that has router field configured and has 
directUpdatesToLeadersOnly=true but is sent without routing info. Also added a 
log.warn when request is sent but no routing info is passed causing request to 
be sent in the general unoptimized route.

> CloudSolrClient fails deleteById with directUpdatesToLeadersOnly but no route 
> passed
> ------------------------------------------------------------------------------------
>
>                 Key: SOLR-18114
>                 URL: https://issues.apache.org/jira/browse/SOLR-18114
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrJ
>            Reporter: Matthew Biscocho
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> CloudSolrClient will fail with the error "directUpdatesToLeadersOnly==true 
> but could not find leader(s)" when a collections has router.name=compositeId 
> and router.field configured and CloudSolrClient has 
> sendDirectUpdatesToShardLeadersOnly= true. 
>  
> [This 
> method|https://github.com/apache/solr/blob/a330e81bd58338ffe464ff058bb67c4bf32e2d00/solr/solrj/src/java/org/apache/solr/client/solrj/impl/CloudSolrClient.java#L1812]
>  does not check if the deleteById map has routing info when it doesn't and so 
> this method return true thinking that the info does exist. So when 
> directUpdatesToLeadersOnly=true, this causes the SERVICE_UNAVAILABLE 
> exception. The deleteById should fallback on the general unoptimized path to 
> complete the deleteById request instead of failing at the client side 
> outright.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to