adityamparikh opened a new pull request, #128: URL: https://github.com/apache/solr-mcp/pull/128
## Summary - Adds a `JVM Docker Integration` job to `ci.yml` that runs both `DockerImageStdioIntegrationTest` and `DockerImageHttpIntegrationTest` against the Jib-built JVM image on every PR. - Drops the `paths:` filter from `native.yml` so `nativeTest`, the native Docker integration job, and the JVM-vs-native benchmark run on every PR (not only PRs that touch native-related files). - Removes the `DockerImageHttpIntegrationTest` exclusion for `-Pnative` builds and the `bootBuildImage` AOT profile lock (plus the `processAot` profile-lock block) so the native image actually serves HTTP at runtime. - Lifts the `SecurityAutoConfiguration` / `ManagementWebSecurityAutoConfiguration` exclusions out of `application-stdio.properties` into a class-level `@SpringBootApplication(excludeName=...)` on `Main.java`, the prerequisite for unlocking AOT. - Replaces a flawed log-grep assertion in `DockerImageHttpIntegrationTest.testHttpModeConfiguration` with a TCP-layer reachability check. The previous assertion checked for "Tomcat started on port" in `docker logs`, which never appeared because the http-profile logback config pipes Spring Boot's startup logs through a CONSOLE + OpenTelemetryAppender pair whose init state suppresses stdout when the OTLP collector is unreachable. The replacement opens a raw socket to the mapped port — a true positive proxy for "HTTP mode is active." End state: every PR exercises four Docker integration combinations — JVM Jib + STDIO, JVM Jib + HTTP, native buildpack + STDIO, native buildpack + HTTP — plus the existing JVM unit and Testcontainers integration tests, `nativeTest`, and the JVM-vs-native benchmark. ## Test plan - [x] `./gradlew clean build dockerIntegrationTest` passes locally on a Linux/macOS dev box. 11 docker tests = 4 STDIO + 7 HTTP, JVM Jib image. - [x] `./gradlew bootBuildImage -Pnative && ./gradlew dockerIntegrationTest -Pnative` passes locally. Same 11 docker tests against the native buildpack image. - [ ] CI: build, unit-tests, integration-tests, jvm-docker-tests, sonarcloud all green. - [ ] CI: nativeTest, native-image, benchmark all green. ## Notes for reviewers - The `OpenTelemetryAppender` install glue may be missing on this branch (no Spring bean appears to call `OpenTelemetryAppender.install(openTelemetry)` after the SDK initializes), which is why Spring Boot's INFO startup logs don't reach `docker logs` under the http profile. That's a pre-existing logging issue, not introduced here. Filing as a follow-up; this PR's scope is intentionally limited to CI plumbing + native HTTP enablement. - The class-level `@SpringBootApplication(excludeName=...)` change is identical in shape to a change already living on the `sb4` Spring Boot 4 fork, which has been running with this configuration since May 1. 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
