squallsama commented on code in PR #4402:
URL: https://github.com/apache/solr/pull/4402#discussion_r3275675908
##########
solr/core/src/java/org/apache/solr/search/QueryParsing.java:
##########
@@ -53,6 +53,7 @@ public class QueryParsing {
public static final char LOCALPARAM_END = '}';
// true if the value was specified by the "v" param (i.e. v=myval, or
v=$param)
public static final String VAL_EXPLICIT = "__VAL_EXPLICIT__";
+ public static final String NAME = "_name";
Review Comment:
Logic behind _name was that this parameter more likely will be used with
MatchedQueryComponent or any other custom component and therefore it's
optional. But I agree that renaming "_name" to "name" is a good suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
