dsmiley commented on code in PR #4402:
URL: https://github.com/apache/solr/pull/4402#discussion_r3285868579
##########
solr/core/src/test/org/apache/solr/search/TestExtendedDismaxParser.java:
##########
Review Comment:
you edited a number of QParser tests to test that "name" works. Have you
seen QueryEqualityTest? That is the one place where all parsers test equality.
I think you could add a handful of examples there and then revert all your
modifications to Test*QParserPlugin.java
##########
solr/solr-ref-guide/modules/query-guide/pages/other-parsers.adoc:
##########
@@ -96,6 +96,17 @@ If this parameter is not set, the usual rules about boolean
queries still apply
Comma separated list of tags for excluding queries from parameters above.
See explanation below.
+`name`::
Review Comment:
shouldn't be here or really anywhere on this page
##########
solr/solr-ref-guide/modules/query-guide/pages/dismax-query-parser.adoc:
##########
@@ -213,7 +213,7 @@ bq={!func}div(sales_rank,ms(NOW,release_date))
bq={!lucene}( {!func v='div(1,sum(1,price))'} )^1.5
----
-=== _name Parameter
+=== name Parameter
Review Comment:
again; this param isn't specific to this parser
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
