vyatkinv commented on code in PR #4320: URL: https://github.com/apache/solr/pull/4320#discussion_r3294293036
########## solr/core/src/java/org/apache/solr/core/InternalSolrClientCache.java: ########## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.core; + +import org.apache.solr.client.solrj.impl.CloudSolrClient; +import org.apache.solr.client.solrj.impl.HttpSolrClientBase; +import org.apache.solr.client.solrj.io.SolrClientCache; +import org.apache.solr.common.SolrException; + +/** A restricted {@link SolrClientCache} that only permits access local solr cluster */ +public class InternalSolrClientCache extends SolrClientCache { + + private static final String ALLOW_EXTERNAL_CLUSTERS_PROPERTY = "solr.allow-external-clusters"; + + public InternalSolrClientCache( + HttpSolrClientBase httpSolrClient, CloudSolrClient.CloudSolrClientConnection solrConnection) { + super(httpSolrClient); + cloudSolClients.put(solrConnection, newCloudSolrClient(solrConnection, httpSolrClient, true)); + } + + public InternalSolrClientCache(HttpSolrClientBase httpSolrClient) { + super(httpSolrClient); + } + + @Override + public void setUseZookeeperACL(boolean useZookeeperACL) { + throw new UnsupportedOperationException( + "Changing ZooKeeper ACL usage is not allowed for InternalSolrClientCache"); + } + + @Override + public synchronized CloudSolrClient getCloudSolrClient( + CloudSolrClient.CloudSolrClientConnection solrConnection) { + CloudSolrClient client = cloudSolClients.get(solrConnection); + if (client != null) { + return client; + } + if (Boolean.getBoolean(ALLOW_EXTERNAL_CLUSTERS_PROPERTY)) { Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
