vyatkinv commented on code in PR #4320:
URL: https://github.com/apache/solr/pull/4320#discussion_r3294201571
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -850,6 +852,8 @@ private void loadInternal() {
registerV2Api(packageLoader.getPackageAPI().editAPI);
registerV2Api(packageLoader.getPackageAPI().readAPI);
registerV2Api(ZookeeperRead.class);
+ } else {
+ solrClientCache = new
InternalSolrClientCache(solrClientProvider.getSolrClient());
Review Comment:
I'm confused by the fact that `StreamHandler`, `SqlHandler`,
`ExportHandler`, and others use `SolrClientCache` regardless of mode. At least
they assign it to a field and pass it to the streaming context. It seems that
eliminating SolrClientCache in non-cloud mode is not a trivial task.
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -850,6 +852,8 @@ private void loadInternal() {
registerV2Api(packageLoader.getPackageAPI().editAPI);
registerV2Api(packageLoader.getPackageAPI().readAPI);
registerV2Api(ZookeeperRead.class);
+ } else {
+ solrClientCache = new
InternalSolrClientCache(solrClientProvider.getSolrClient());
Review Comment:
I'm confused by the fact that `StreamHandler`, `SqlHandler`,
`ExportHandler`, and others use `SolrClientCache` regardless of mode. At least
they assign it to a field and pass it to the streaming context. It seems that
eliminating `SolrClientCache` in non-cloud mode is not a trivial task.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
