epugh commented on code in PR #4320:
URL: https://github.com/apache/solr/pull/4320#discussion_r3298558257
##########
solr/core/src/java/org/apache/solr/core/CoreContainer.java:
##########
@@ -850,6 +852,8 @@ private void loadInternal() {
registerV2Api(packageLoader.getPackageAPI().editAPI);
registerV2Api(packageLoader.getPackageAPI().readAPI);
registerV2Api(ZookeeperRead.class);
+ } else {
+ solrClientCache = new
InternalSolrClientCache(solrClientProvider.getSolrClient());
Review Comment:
My understanding is that none of those features were designed to work in non
cloud mode, the assumption was that they wouldn't. There also was a
relunctance to I think to start supporting it in non cloud mode if that isnt' a
common use case, as then it increases our testing and maintenance burden. As
a community, we don't have a shared understanding of what is in cloud mode
versus not, and what our overall goal is. You are seeing this in the code ;-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
