vyatkinv commented on code in PR #4320:
URL: https://github.com/apache/solr/pull/4320#discussion_r3299161841
##########
solr/modules/sql/src/java/org/apache/solr/handler/sql/CalciteSolrDriver.java:
##########
@@ -87,7 +89,13 @@ public Connection connect(String url, Properties info)
throws SQLException {
if (schemaName == null) {
throw new SQLException("zk must be set");
}
- final SolrSchema solrSchema = new SolrSchema(info, solrClientCache);
+ var solrConnection =
CloudSolrClient.CloudSolrClientConnection.parse(schemaName);
+ if (!solrConnection.isZookeeper()) {
+ throw new SQLException(
+ String.format(
+ Locale.ROOT, "Expected ZooKeeper connection string, but got:
'%s'.", schemaName));
+ }
Review Comment:
removed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
