dsmiley commented on code in PR #4320:
URL: https://github.com/apache/solr/pull/4320#discussion_r3312328136
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/TupleStream.java:
##########
@@ -213,14 +225,67 @@ public static List<String> getShards(
}
} else {
shards =
- getReplicas(zkHost, collection, streamContext,
requestParams).stream()
+ getReplicas(solrConnection, collection, streamContext,
requestParams).stream()
.map(Replica::getCoreUrl)
.collect(Collectors.toList());
}
return shards;
}
+ public static CloudSolrClient.CloudSolrClientConnection buildSolrConnection(
Review Comment:
An argument could be made for this being an instance method of
streamFactory. It's a required param and calls 2 of its methods, one of which
is similar to this one. That one is named differently,
`getConnectionForCollection` vs `buildSolrConnection` but this is really the
same concept. WDYT?
##########
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/expr/StreamExpression.java:
##########
@@ -76,6 +78,14 @@ public void setParameters(List<StreamExpressionParameter>
parameters) {
this.parameters = parameters;
}
+ public void addParameters(SolrParams parameters) {
Review Comment:
The next method has this signature:
`public StreamExpression withParameters(List<StreamExpressionParameter>
parameters)`
Shouldn't this method here, which calls that one, use the same style?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
