rahulgoswami commented on PR #4461: URL: https://github.com/apache/solr/pull/4461#issuecomment-4571183298
I tried to revisit my comments on [SOLR-17715](https://issues.apache.org/jira/browse/SOLR-17715) and recollect hitting a wall with respect to truly being able to remove "qt" . I will need to come back to this PR once I have refreshed my memory of some of those details and correlate to @gerlowskija's suggestions. Having said that, if the motivation behind reversing the deprecation is the unintended effect you alluded to - `solrQuery.set("qt", "/ourHandler")` - which I agree makes the code worse for tracking and fixing when qt is eventually removed, can this be solved by adding a message in the deprecation itself to the effect of "don't do something like this - `solrQuery.set("qt", "/ourHandler")` - to get around the deprecation"? One caution against reversing the deprecation in the world of agentic coding is that un-deprecating the method might encourage usage of "qt" by LLMs since there is no directive around avoiding the usage, vs a clearer deprecation message which can nudge them towards a preferred pattern (request.setPath() and request.process()). I admit I am making an assumption here that LLMs do consider deprecations while using APIs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
