rahulgoswami commented on code in PR #4461:
URL: https://github.com/apache/solr/pull/4461#discussion_r3565744065
##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/SolrQuery.java:
##########
@@ -1134,14 +1134,16 @@ public Integer getStart() {
}
/**
- * The Request Handler to use (see the solrconfig.xml), which is stored in
the "qt" parameter.
- * Normally it starts with a '/' and if so it will be used by {@link
- * org.apache.solr.client.solrj.request.QueryRequest#getPath()} in the URL
instead of the "qt"
- * parameter. If this is left blank, then the default of "/select" is
assumed.
+ * The Request Handler to use (see the solrconfig.xml), starting with a '/'.
This isn't passed to
+ * Solr as a parameter; instead {@link QueryRequest} uses it for the path.
QueryRequest uses
+ * "/select" if no path or request-handler is provided. Since this isn't
<em>really</em> a
+ * parameter in practice, it's preferrable to set this in the constructor of
QueryRequest, or the
+ * setter instead.
*
* @param qt The Request Handler name corresponding to one in solrconfig.xml
on the server.
* @return this
- * @deprecated Use {@link SolrRequest#setPath(String)}
+ * @deprecated QueryRequest#QueryRequest(String, SolrParams)
Review Comment:
nit: @deprecated _Use_ QueryRequest#QueryRequest(String, SolrParams)
Missing "Use"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
