heitzjm opened a new pull request, #4479: URL: https://github.com/apache/solr/pull/4479
https://issues.apache.org/jira/browse/SOLR-18270 # Description The parameter used by the cert auth plugin to get the SSL client certificate can be configured in security.json, as the attribute name changed (java EE => jakarta EE) # Solution This PR adds the parameter and its usage, as well as adds some tests, and updates the documentation. # Tests Class solr/core/src/test/org/apache/solr/security/CertAuthPluginRequestAttributeTest.java : adds parametrized test to ensure that the default value works, and that a custom value is taken into account. The class heavily borrows code from solr/core/src/test/org/apache/solr/security/CertAuthPluginTest.java # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended, not available for branches on forks living under an organisation) - [x] I have developed this patch against the `main` branch. - [x] I have run `./gradlew check`. ``` > Task :solr:core:test :solr:core:test (FAILURE): 5586 test(s), 1 failure(s), 183 skipped 5586 tests completed, 1 failed, 183 skipped > Task :solr:solr-ref-guide:test :solr:solr-ref-guide:test (SUCCESS): 40 test(s) ... ERROR: The following test(s) have failed: - org.apache.solr.TestDistributedGrouping.test (:solr:core) Test history: https://develocity.apache.org/scans/tests?search.rootProjectNames=solr-root&tests.container=org.apache.solr.TestDistributedGrouping&tests.test=test http://fucit.org/solr-jenkins-reports/history-trend-of-recent-failures.html#series/org.apache.solr.TestDistributedGrouping.test Test output: /tmp/SOLR/solr/core/build/test-results/test/outputs/OUTPUT-org.apache.solr.TestDistributedGrouping.txt Reproduce with: ./gradlew :solr:core:test --tests "org.apache.solr.TestDistributedGrouping.test" "-Ptests.jvmargs=-XX:TieredStopAtLevel=1 -XX:+UseParallelGC -XX:ActiveProcessorCount=1 -XX:ReservedCodeCacheSize=120m" -Ptests.seed=34687A3DF4AB53C4 -Ptests.useSecurityManager=true -Ptests.file.encoding=ISO-8859-1 ``` The test failed because of a timeout. I reran the test only after that, and it then succeeded. - [x] I have added tests for my changes. - [x] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) - [x] I have added a [changelog entry](https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc) for my change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
