heitzjm commented on PR #4479: URL: https://github.com/apache/solr/pull/4479#issuecomment-4594616107
Fine, I am going to implement the fallback in the PR 4474. However, to me, the attribute name is not an internal servlet detail : it is a kind of "contract" between the application server and the application - and the attribute name appears in specs (Jakarta Servlet Specifications - https://jakarta.ee/specifications/servlet/). So, I think it would be great to add a comment in the CertAuthPlugin documentation about it. In fact, it was difficult for me to find out what went wrong, so adding a note about the importance of the spec might help other users in some (I hope unlikely) use cases. What do you think? Le lun. 1 juin 2026 à 18:09, Lamine ***@***.***> a écrit : > *laminelam* left a comment (apache/solr#4479) > <https://github.com/apache/solr/pull/4479#issuecomment-4594366257> > > This is not an authentication policy choice, it's an internal servlet > details that does not need to be exposed to the user. > I think, your other PR <https://github.com/apache/solr/pull/4474> is more > appropriate to solve the issue. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/solr/pull/4479?email_source=notifications&email_token=AVJXZPBF2S5ZMMOMRWWWPG345WTELA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJZGQZTMNRSGU32M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-4594366257>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AVJXZPA4UKESNOMQVTFJUVL45WTELAVCNFSM6AAAAACZT5OZBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DKOJUGM3DMMRVG4> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/AVJXZPDDYQWDJTJU56J7QIL45WTELA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJZGQZTMNRSGU32M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> > and Android > <https://github.com/notifications/mobile/android/AVJXZPD4INOLKRIIJPBNXNL45WTELA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTINJZGQZTMNRSGU32M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. > Download it today! > You are receiving this because you authored the thread.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
