epugh commented on PR #4478: URL: https://github.com/apache/solr/pull/4478#issuecomment-4586990724
An interesting things about the AI generated code comments is that I really like them to help me understand "this is the migraiton, this is what was before, this is how we do it now", but that the life span of that comment is that of the PR, once the PR is merged, I wish the comment disappeared. I think that some of the "self review" comments people put into PR's accomplish that same goal. I also expect at some point that in a `git diff` you will someday see files that are added/changed/removed, and then a set of files that are marked to be deleted WHEN the PR is merged. I know I often have a `notes.md` file that accidentally gets committed that is my notes to myself when working on the code. It would be nice if we could label files as only lasting as long as the PR is open! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
