janhoy commented on code in PR #4478:
URL: https://github.com/apache/solr/pull/4478#discussion_r3358164778


##########
solr/packaging/test/README.md:
##########
@@ -55,6 +55,24 @@ Some tests will start clusters or create collections,
 
 It is recommended that you install and run `shellcheck` to verify your test 
scripts and catch common mistakes before committing your changes.
 
+## Nightly Tests
+
+Some BATS tests are slow or require network access (e.g. downloading models) 
and are
+excluded from regular runs by default. These tests use BATS native tagging via
+`# bats test_tags=nightly` and are filtered out with `--filter-tags !nightly`.
+
+To include nightly tests, pass the Gradle property `solr.bats.nightly`:
+
+    ./gradlew integrationTests -Psolr.bats.nightly=true

Review Comment:
   > @dsmiley wrote: Sounds like we should have a general concept of "nightly" 
BATS.
   
   Did some research and wired in BATS concept of test tagging. So now we can 
tag slow tests as done for `test_opennlp.bats` and they will only run when 
gradle is invoked with `-Psolr.bats.nightly=true`.
   
   Thus we can configure Jenkins with this prop...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to