dsmiley commented on code in PR #4109:
URL: https://github.com/apache/solr/pull/4109#discussion_r3428036824
##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/UpdateRequest.java:
##########
@@ -166,14 +171,32 @@ public UpdateRequest deleteById(String id) {
return this;
}
+ /**
+ * For deleting a doc, and identifying the correct shard via a {@code
_route_}. For a typical
+ * collection ({@code compositeId} router and without {@code router.field}
specified), there's no
+ * need for this since Solr knows the correct shard using only the "id".
Otherwise, and without a
+ * route, Solr blasts this out to all shards, which is suboptimal.
+ *
+ * @param route a {@code _route_} for this document
+ */
public UpdateRequest deleteById(String id, String route) {
return deleteById(id, route, null);
}
+ /**
Review Comment:
Thanks... that has been almost half my effort, to include researching the
finer points.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
