dsmiley commented on code in PR #4109:
URL: https://github.com/apache/solr/pull/4109#discussion_r3428077844
##########
solr/solrj/src/java/org/apache/solr/client/solrj/request/AbstractUpdateRequest.java:
##########
@@ -26,30 +28,90 @@ public abstract class AbstractUpdateRequest extends
CollectionRequiringSolrReque
protected ModifiableSolrParams params = new ModifiableSolrParams(); // maybe
make final; no setter
protected int commitWithin = -1;
+ public AbstractUpdateRequest(METHOD m, String path) {
+ super(m, path, SolrRequestType.UPDATE);
+ }
+
+ public enum CommitOption {
Review Comment:
I've been thinking of the soft vs hard matter and I would rather our users
not know much about soft vs hard; IMO it should be automatic, with the option
to be explicit if you _really_ want to. Most commits should become soft due to
the updateLog. Not when optimize or expungeDeletes. Not if there's no
updateLog at all.
A recent post on our lists show that the soft vs hard commit made a huge
difference for their tests... and I suspect it would improve our tests
significantly too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
