dsmiley commented on code in PR #4475:
URL: https://github.com/apache/solr/pull/4475#discussion_r3444285500
##########
solr/core/src/test/org/apache/solr/search/TestMmBoolQParserPlugin.java:
##########
@@ -109,6 +110,20 @@ public void testMinShouldMatchThresholdsLower() throws
Exception {
assertEquals(expected, actual);
}
+ @Test
+ public void testMinShouldMatchWithEmptyClauseCausedByStopWord() throws
Exception {
+
+ Query actual =
+ parseQuery(req("q", "{!bool should=name:foo should=name:bar
should=teststop:to mm=-1}"));
+
+ BooleanQuery expected =
+ shouldBuilder("foo", "bar")
+ .setMinimumNumberShouldMatch(1)
Review Comment:
I'm guessing this is undesirable -- we want 2? If so, a comment e.g.
"nocommit" would communicate intent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
