renatoh commented on PR #4475: URL: https://github.com/apache/solr/pull/4475#issuecomment-4767805720
> I'm coming around to a null check in org.apache.solr.search.join.FiltersQParser.parseImpl but not so heavily guarded by lots of conditions. And it needs a comment, of course. My only change left to org.apache.solr.search.join.FiltersQParser.parseImpl is the in-lining of the variable query and occur, which I have reverted just now since how it use how it used to be looks more readable to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
