markrmiller commented on code in PR #4514: URL: https://github.com/apache/solr/pull/4514#discussion_r3470038573
########## solr/core/src/java/org/apache/solr/util/circuitbreaker/MemoryCircuitBreaker.java: ########## @@ -17,75 +17,145 @@ package org.apache.solr.util.circuitbreaker; -import java.io.IOException; import java.lang.invoke.MethodHandles; import java.lang.management.ManagementFactory; import java.lang.management.MemoryMXBean; +import java.lang.management.MemoryPoolMXBean; +import java.lang.management.MemoryType; +import java.lang.management.MemoryUsage; +import java.util.ArrayList; +import java.util.List; import java.util.Locale; -import org.apache.solr.util.RefCounted; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.regex.Pattern; +import org.apache.solr.common.util.EnvUtils; import org.slf4j.Logger; import org.slf4j.LoggerFactory; /** - * Tracks the current JVM heap usage and triggers if a moving heap usage average over 30 seconds - * exceeds the defined percentage of the maximum heap size allocated to the JVM. Once the average - * memory usage goes below the threshold, it will start allowing queries again. + * Trips when post-collection live data in the JVM heap exceeds a configured percentage of the Review Comment: Agree, I'll use "post-GC". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
