markrmiller commented on code in PR #4514: URL: https://github.com/apache/solr/pull/4514#discussion_r3469925581
########## changelog/unreleased/SOLR-18284-load-and-memory-circuit-breakers.yml: ########## @@ -0,0 +1,8 @@ +# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc +title: Load-average and memory circuit breakers no longer stampede or trip on transient pre-GC heap peaks Review Comment: Agree the entry is thin, though both terms are fairly standard IMO: "stampede" is well known from cache stampede and in distributed contexts, though sometimes "thundering herd" is also used, and "trip" is the normal word for a circuit breaker firing. If there is an issue, it's in detail, not vocabulary I think. I will split it into two files though, roughly: - `LoadAverageCircuitBreaker now caches its sampled value for a short TTL, so it stops re-polling the OS load average per request at high RPS.` - `MemoryCircuitBreaker now measures post-GC live heap data, so it no longer trips when the heap is full of collectible garbage.` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
