markrmiller commented on code in PR #4514: URL: https://github.com/apache/solr/pull/4514#discussion_r3469930748
########## solr/core/src/java/org/apache/solr/util/circuitbreaker/TtlSampledMetric.java: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.util.circuitbreaker; + +import java.util.concurrent.TimeUnit; +import java.util.concurrent.atomic.AtomicBoolean; +import java.util.concurrent.atomic.AtomicReference; +import java.util.function.Supplier; + +/** + * Single-flight, time-bounded cache around an expensive metric sample. + * + * <ul> Review Comment: You are right. get() is the whole surface, and it exposes none of that split. I will drop the taxonomy from the class javadoc and keep those notes as inline comments on each branch in get(), where most of them already are. The class javadoc will just state the contract: a time-bounded single-flight cache; the sampler runs at most once per TTL window, even under a concurrent stampede. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
