serhiy-bzhezytskyy opened a new pull request, #4573: URL: https://github.com/apache/solr/pull/4573
https://issues.apache.org/jira/browse/SOLR-18296 # Description Bumps google-java-format from 1.18.1 to 1.35.0. The Java baseline is unchanged (JDK 21); this only affects the spotless code formatter. google-java-format 1.18.1 calls a javac internal, `Log$DeferredDiagnosticHandler.getDiagnostics()`, whose signature changed in JDK 24, so `gradlew tidy` / `spotlessApply` throws `NoSuchMethodError` on JDK 24+. 1.34.0+ adds support for newer JDKs; 1.35.0 is the current release. # Changes - `gradle/libs.versions.toml`: `google-javaformat` 1.18.1 -> 1.35.0 - re-ran `gradlew tidy`: ~35 files reformatted (minor, mechanical — the new formatter version's rules), no logic changes - spotless (8.3.0) drives the new version with no other change - changelog entry added under `changelog/unreleased/` # Testing `gradlew spotlessJavaCheck` passes on Eclipse Temurin 21 and on JDK 25. # Notes for reviewers - Discussed on dev@ before opening (thread: "Upgrading google-java-format (spotless) — fixes JDK 24/25 build break"); no objection (thanks David). # AI assistance disclosure Per Solr's AGENTS.md / how-to-contribute guidance: this change was prepared with the assistance of an AI coding agent and reviewed by me for correctness, scope, and alignment with Solr's build conventions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
