serhiy-bzhezytskyy commented on PR #4573: URL: https://github.com/apache/solr/pull/4573#issuecomment-4850020838
Thanks @janhoy and @dsmiley. I've restructured this into a fresh PR: #4578 - commit 1: the 1.35.0 bump + changelog - commit 2: the ~35 reformatted files (isolated), added to .git-blame-ignore-revs - commit 3: the blame-ignore entry One note on the two-PR suggestion: for a pure formatter *version* bump the bump and the reformat can't be separated — each fails spotlessJavaCheck alone (bump alone → unformatted files; reformat alone → gjf 1.18.1 crashes on JDK 25, which is the bug this fixes). So I kept them in one PR with the reformat isolated in its own commit per Jan's suggestion, which preserves the blame-ignore SHA. Closing this in favour of #4578. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
