VishnuPriyaChandraSekar commented on code in PR #4626:
URL: https://github.com/apache/solr/pull/4626#discussion_r3555446241
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/ConcurrentUpdateJdkSolrClientTest.java:
##########
@@ -28,7 +28,11 @@ public HttpSolrClient solrClient(Integer
overrideIdleTimeoutMs) {
var builder =
new
HttpJdkSolrClient.Builder().withSSLContext(MockTrustManager.ALL_TRUSTING_SSL_CONTEXT);
if (overrideIdleTimeoutMs != null) {
- builder.withIdleTimeout(overrideIdleTimeoutMs, TimeUnit.MILLISECONDS);
+ builder
+ .withIdleTimeout(overrideIdleTimeoutMs, TimeUnit.MILLISECONDS)
+ // override the infinite request timeout with idle timeout to ensure
idle requests times
+ // out.
+ .withRequestTimeout(overrideIdleTimeoutMs, TimeUnit.MILLISECONDS);
Review Comment:
In case of JDK, the only way to terminate a connection/request is by using
request timeout. Hence I cannot use infinite timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
