dsmiley commented on code in PR #4626:
URL: https://github.com/apache/solr/pull/4626#discussion_r3609140296
##########
solr/solrj/src/test/org/apache/solr/client/solrj/impl/LB2SolrClientTest.java:
##########
@@ -405,6 +405,9 @@ private class TimeoutZombieTestContext implements
AutoCloseable {
new HttpJettySolrClient.Builder()
.withConnectionTimeout(1000, TimeUnit.MILLISECONDS)
.withIdleTimeout(1, TimeUnit.MILLISECONDS)
+ // override the infinite request timeout with idle timeout to
ensure idle requests
+ // times out.
Review Comment:
RE "this test": LB2SolrClientTest is a test suite with a number of tests,
and this comment thread is on a general part of the test suite. Hopefully the
"connect" timeout ones are valid; yes? So I suppose your input is that the
"testTimeoutExceptionMarksServerAsZombie" test and Async one are flawed?
If the default idle timeout of -1 is actually used as such for the first
response, even in the beginning... this is a problem IMO. If we have the
intended/desired idle timeout then we can use that. If we don't, I suppose the
connection timeout would be a reasonable substitute.
Obviously what we do will need some comments to help anyone studying the
internals understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
