epugh commented on code in PR #4669:
URL: https://github.com/apache/solr/pull/4669#discussion_r3667768746
##########
solr/solrj/src/java/org/apache/solr/common/SolrException.java:
##########
@@ -23,14 +23,10 @@
import java.util.Map;
import org.apache.solr.common.util.NamedList;
import org.apache.solr.common.util.SimpleOrderedMap;
-import org.slf4j.Logger;
-import org.slf4j.MDC;
/** */
public class SolrException extends RuntimeException {
- private final Map<String, String> mdcContext;
Review Comment:
@psalagnac would you weigh in on this? Is there any side effect that I
don't understand why we need to set this if we never read it? On my first
pass, I left it b/c I didn't understand it. On my second pass I decided maybe
it was just dead code... Would love your eyes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
