psalagnac commented on code in PR #4669:
URL: https://github.com/apache/solr/pull/4669#discussion_r3667997894
##########
solr/solrj/src/java/org/apache/solr/common/SolrException.java:
##########
@@ -23,14 +23,10 @@
import java.util.Map;
import org.apache.solr.common.util.NamedList;
import org.apache.solr.common.util.SimpleOrderedMap;
-import org.slf4j.Logger;
-import org.slf4j.MDC;
/** */
public class SolrException extends RuntimeException {
- private final Map<String, String> mdcContext;
Review Comment:
This exception is available in SolrJ, so the only usage I image is a caller
that catches it can know some details on the context.
```
try {
doStuff();
} catch (SolrException e) {
e.logInfoWithMdc(myLogger, "oh no!");
}
```
But I don't know if we set MDC context on clients, and honestly I would not
rely on this.
I don't have any concerns with removing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
