[
https://issues.apache.org/jira/browse/SOLR-17697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18100471#comment-18100471
]
ASF subversion and git services commented on SOLR-17697:
--------------------------------------------------------
Commit 76cb3271abf52e4d793c841b8116df1daf8a0a8c in solr's branch
refs/heads/jira/SOLR-17697-picocli from Jan Høydahl
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=76cb3271abf ]
Merge remote-tracking branch 'upstream/main' into jira/SOLR-17697-picocli
# Conflicts:
# solr/api/gradle.lockfile
# solr/benchmark/gradle.lockfile
# solr/core/gradle.lockfile
# solr/core/src/java/org/apache/solr/cli/ConfigSetUploadTool.java
# solr/core/src/java/org/apache/solr/cli/CreateTool.java
# solr/core/src/java/org/apache/solr/cli/DeleteTool.java
# solr/core/src/java/org/apache/solr/cli/StatusTool.java
# solr/core/src/java/org/apache/solr/cli/VersionTool.java
# solr/cross-dc-manager/gradle.lockfile
# solr/modules/analysis-extras/gradle.lockfile
# solr/modules/clustering/gradle.lockfile
# solr/modules/cross-dc/gradle.lockfile
# solr/modules/cuvs/gradle.lockfile
# solr/modules/extraction/gradle.lockfile
# solr/modules/gcs-repository/gradle.lockfile
# solr/modules/jwt-auth/gradle.lockfile
# solr/modules/langid/gradle.lockfile
# solr/modules/language-models/gradle.lockfile
# solr/modules/ltr/gradle.lockfile
# solr/modules/opentelemetry/gradle.lockfile
# solr/modules/s3-repository/gradle.lockfile
# solr/modules/scripting/gradle.lockfile
# solr/modules/sql/gradle.lockfile
# solr/packaging/build.gradle
# solr/packaging/test/test_create.bats
# solr/server/gradle.lockfile
# solr/solr-ref-guide/gradle.lockfile
# solr/solrj-jetty/gradle.lockfile
# solr/solrj-streaming/gradle.lockfile
# solr/solrj-zookeeper/gradle.lockfile
# solr/solrj/gradle.lockfile
# solr/test-framework/build.gradle
# solr/test-framework/gradle.lockfile
# solr/webapp/gradle.lockfile
> Use picocli instead of commons-cli
> ----------------------------------
>
> Key: SOLR-17697
> URL: https://issues.apache.org/jira/browse/SOLR-17697
> Project: Solr
> Issue Type: Improvement
> Components: cli
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Priority: Major
> Labels: pull-request-available
> Time Spent: 9h
> Remaining Estimate: 0h
>
> Apache commons-cli has served us well for years, but our CLI has out-grown
> its capabilities, with multiple sub commands and a plethora of options and
> arguments. We have much custom code to work around limitations.
> By embracing [Picocli|https://picocli.info/], an annotation based cli
> framework, it will be easier to maintain the cli and add further tools. We
> propose to target 10.1 and do work gradually in a feature branch.
> The feature branch is {{{}jira/SOLR-17697-picocli{}}}, you can view it in a
> [draft PR not intended for merge|https://github.com/apache/solr/pull/3254].
> That PR has a description on how to contribute, and a checklist of tools not
> yet converted. Once all tools are converted, all tests are green and all docs
> updated, we can merge this work.
> There is an env var {{SOLR_PICOCLI=true}} that we currently use to swtich
> from old commons-cli and new picocli. Once the feature branch is merged we
> can choose to make SOLR_PICOCLI default to true but retain the old
> commons-cli parser code for a few releases, so there will be a workaround for
> potential bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]