[
https://issues.apache.org/jira/browse/SOLR-17697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18100759#comment-18100759
]
Eric Pugh commented on SOLR-17697:
----------------------------------
I think we are kidding ourselves that anyone beyond a tiny group of folks will
ever flip the opt-in feature. This isn't some exciting new vector
implmeentation ;). Also, I am hoping that we get this done sooner versus
later.
I would be sad if we left the refg guide stuff behind, only because then I
worry the work around doing nicer documetnation of the features would never get
done.
Are we really that far from just finishing the picocli branch? Looking at
your checklist, you have tackled the hardest ones, especially once AuthTool
lands.
I think, if you want to run both at the same time, just have both commons-cli
and piccoli run in paralale, and not worry about the opt in.
To my mind, the picocli stuff is great. Also, since I know you [~janhoy] , I
have no concerns about you abandoning the work... And I'm also
interested/committed to see ing it done!
> Use picocli instead of commons-cli
> ----------------------------------
>
> Key: SOLR-17697
> URL: https://issues.apache.org/jira/browse/SOLR-17697
> Project: Solr
> Issue Type: Improvement
> Components: cli
> Reporter: Jan Høydahl
> Assignee: Jan Høydahl
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10.5h
> Remaining Estimate: 0h
>
> Apache commons-cli has served us well for years, but our CLI has out-grown
> its capabilities, with multiple sub commands and a plethora of options and
> arguments. We have much custom code to work around limitations.
> By embracing [Picocli|https://picocli.info/], an annotation based cli
> framework, it will be easier to maintain the cli and add further tools. We
> propose to target 10.1 and do work gradually in a feature branch.
> The feature branch is {{{}jira/SOLR-17697-picocli{}}}, you can view it in a
> [draft PR not intended for merge|https://github.com/apache/solr/pull/3254].
> That PR has a description on how to contribute, and a checklist of tools not
> yet converted. Once all tools are converted, all tests are green and all docs
> updated, we can merge this work.
> There is an env var {{SOLR_PICOCLI=true}} that we currently use to swtich
> from old commons-cli and new picocli. Once the feature branch is merged we
> can choose to make SOLR_PICOCLI default to true but retain the old
> commons-cli parser code for a few releases, so there will be a workaround for
> potential bugs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
