janhoy opened a new pull request, #4688: URL: https://github.com/apache/solr/pull/4688
Preparatory refactor for the picocli migration (SOLR-17697), extracted so it can land on `main` independently of the picocli branch. Restructures `AuthTool`'s monolithic `handleBasicAuth(cli)` into: - an `AuthParams` record holding all sub-command parameters, including the **resolved** ZooKeeper connection string as a plain nullable `String zkHost` - parser-independent `handleCommand()` / `enableBasicAuth()` / `disableBasicAuth()` / `clearSecurityJson()` methods The ZK host is resolved once in `runImpl` (skipped with `--update-include-file-only`, so no connection is attempted when none is needed); all user-facing error reporting stays at the existing check sites. No functional change intended — the only behavior delta is that `auth disable` against an unreachable Solr now prints the friendly "ZK Host not found" message instead of propagating a raw exception. On the picocli branch, apache/solr#4684 then adds a `callTool()` that builds the same `AuthParams` and calls the same `handleCommand()`, addressing https://github.com/apache/solr/pull/4684#discussion_r3684834976 (no `Callable` needed). Verified with `AuthToolTest` and `gradlew tidy`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
