janhoy commented on PR #4688: URL: https://github.com/apache/solr/pull/4688#issuecomment-5141896453
@epugh I think landing the basic refactor / method extraction part of a tool migration on main is a good practice. Then the diff in the huge picocli PR branch is minimized to the picocli parts, and less risk of conflicts. Perhaps this tool was worse than others, a huge part of the code had to be moved around as it was all smashed into one method... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
