dsmiley commented on PR #4695: URL: https://github.com/apache/solr/pull/4695#issuecomment-5173267794
> As a praparatory step before porting the remaining CLI tools to picocli ([SOLR-17697](https://issues.apache.org/jira/browse/SOLR-17697)), this PR refactors some tools to not depend on commons-cli specific method arguments, e.g. CommandLine. I'm missing the point/value of this PR. Why is it worthwhile to decouple the tool from the CLI framework? They live very much together. I see some use of records here containing lots of values, which means calling a record constructor with very high "arity". The reader (me) has to take it on faith that Xth argument is what we think it is. Ah a string... surely that can't be confused with any other string ;-) Unfortunately java doesn't suppoert naming the parameter at the call-site. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
