janhoy commented on PR #4695: URL: https://github.com/apache/solr/pull/4695#issuecomment-5180450554
Addressed the arity concerns in some records in the three latest commits, taking different approaches depending on the tool: - **AssertTool** (13 → 5 args): the nine assertion flags are now a `List<Assertion>` — a sealed interface with one small record per assertion kind, run via an exhaustive switch. Call-sites read `new Assertion.DirExists(dir)` etc. - **RunExampleTool** (12 → 7/4/5): split into mode-specific `RunExampleParams` / `CloudExampleParams`, both embedding a shared `StartSolrParams` with the fields `startSolr` actually uses. - **PostTool** (13 → 8): grouped into smaller self-describing records: `ContentOptions`, `CrawlOptions`, `UpdateOptions`. The remaining records are ≤8 components of mostly independent options, left as-is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
