dsmiley commented on code in PR #4640:
URL: https://github.com/apache/solr/pull/4640#discussion_r3708850909
##########
solr/solrj/src/test/org/apache/solr/client/solrj/SolrExampleJsonMapTest.java:
##########
@@ -14,28 +14,19 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.solr.client.solrj.response;
+package org.apache.solr.client.solrj;
-import org.apache.solr.SolrTestCase;
+import org.apache.solr.SolrTestCaseJ4.SuppressSSL;
import org.apache.solr.client.solrj.response.json.JsonMapResponseParser;
-import org.junit.Test;
-/**
- * Pins the producesCanonicalForm() contract that gates response
normalization: only the JSON map
- * parser (which yields raw Maps/Lists) needs normalizing; the parsers that
already produce the
- * canonical NamedList/SolrDocumentList shape must report true so they pass
through untouched.
- */
-public class ResponseParserCanonicalFormTest extends SolrTestCase {
-
- @Test
- public void testCanonicalParsersReportTrue() {
- assertTrue(new JavaBinResponseParser().producesCanonicalForm());
- assertTrue(new XMLResponseParser().producesCanonicalForm());
- assertTrue(new InputStreamResponseParser("json").producesCanonicalForm());
- }
-
- @Test
- public void testJsonMapParserReportsFalse() {
- assertFalse(new JsonMapResponseParser().producesCanonicalForm());
+/** Runs the example tests over {@link JsonMapResponseParser}. */
Review Comment:
Niiiiice.... :-) thank you. Should be getting lots more coverage here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
