dsmiley commented on code in PR #4640: URL: https://github.com/apache/solr/pull/4640#discussion_r3942034667
########## changelog/unreleased/SOLR-17316-response-parsers.yml: ########## @@ -0,0 +1,12 @@ +# See https://github.com/apache/solr/blob/main/dev-docs/changelog.adoc + +title: > + SolrJ's QueryResponse and other response objects now work when the client is configured with a + non-binary response parser (such as the JSON parser); previously their accessors could throw a + ClassCastException. Review Comment: ```suggestion JSON response parser (namely `JsonMapResponseParser`); previously their accessors could throw ClassCastException. ``` I think we should just name JsonMapResponseParser specifically, as we know this works. JacksonDataBindResponseParser probably doesn't work. Albeit it'd be interesting to try experimentally. I'm definitely keen on use of Jackson for CBOR support. For Solr 11, I hope we can use Jackson inside JsonMapResponseParser instead of noggit, but that's a separate discussion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
