serhiy-bzhezytskyy opened a new pull request, #4754: URL: https://github.com/apache/solr/pull/4754
Removes all 9 deprecated `SolrIndexSearcher` members the ticket names — `search(QueryResult, QueryCommand)` plus 8 `getDocList`/`getDocListAndSet` overloads — and the 3 already-commented-out `doc(...)` blocks with their stale javadoc. `@Deprecated` count 12 → 0, verified by listing each exact signature against `origin/main`, not by counting. One correction to the ticket text: none of the 9 carry an explicit `@deprecated Use X instead` javadoc sentence — the replacement is visible only in each method's own body, not its documentation. 5 in-tree call sites migrated (4 in `MoreLikeThisHandler`, 1 in `HighlighterTest`) — the only ones in the whole tree; a naive grep returns ~100 hits, almost all surviving overloads or unrelated classes. 84 tests, 0 failures. On the ticket's own caution about third-party usage: no `@lucene.experimental`/internal markers, no ref-guide/upgrade-notes mentions either way. The deprecation shipped in 10.0.0 (`#2524`, 2024-07-03), so it's had a real release's exposure. Two small cleanups made possible by the removal: `search(QueryCommand)`'s body is now the two lines the deprecated overload contained, and `getDocListC` builds its own `QueryResult` instead of taking one as an always-fresh, discarded-by-callers out-parameter — resolving the `// TODO don't take QueryResult as arg` comment that sat on it. AI-assisted (Claude Sonnet 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
