epugh commented on code in PR #4754:
URL: https://github.com/apache/solr/pull/4754#discussion_r3813614914


##########
solr/core/src/test/org/apache/solr/highlight/HighlighterTest.java:
##########
@@ -1397,7 +1398,14 @@ public void payloadFilteringSpanQuery() throws 
IOException {
       SolrQueryResponse resp = new SolrQueryResponse();
       ResponseBuilder rb = new ResponseBuilder(req, resp, List.of(hlComp));
       rb.setHighlightQuery(query);
-      rb.setResults(req.getSearcher().getDocListAndSet(query, null, 0, 1));
+      rb.setResults(
+          new QueryCommand()
+              .setQuery(query)
+              .setOffset(0)
+              .setLen(1)
+              .setNeedDocSet(true)

Review Comment:
   should there have been setFlags first??



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to