epugh commented on code in PR #4750: URL: https://github.com/apache/solr/pull/4750#discussion_r3813662907
########## solr/modules/clustering/src/java/org/apache/solr/handler/clustering/FlatKeysAttrVisitor.java: ########## Review Comment: yeah, I find it incredibly hard to be so diciplicned. I see these obvious small typos and grammer errors. in someways, I don't understand how they still exist considering I feel like I've been through the entire code base more then once fixing typos and grammer issues, but clearly not. ########## solr/modules/clustering/src/java/org/apache/solr/handler/clustering/FlatKeysAttrVisitor.java: ########## Review Comment: i will try and split out the typos into another PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
