epugh commented on code in PR #4750:
URL: https://github.com/apache/solr/pull/4750#discussion_r3814026379
##########
solr/modules/analysis-extras/src/java/org/apache/solr/schema/ICUCollationField.java:
##########
@@ -105,9 +105,9 @@ public class ICUCollationField extends FieldType {
private static void warnOrFailUdvas(boolean failHardOnUdvas) {
// NOTE: it may seem odd that we're checking these conditions ourselves
rather than relying on
- // the internal
- // checking of `assertWarnOrFail(...)`. But the main reason we're logging
this error via
- // `XMLConfigFile.assertWarnOrFail(...)` is because this is at its root an
xml config file
+ // the internal checking of `assertWarnOrFail(...)`. But the main reason
we're logging this
+ // error via
+ // `XMLConfigFile.assertWarnOrFail(...)` is because this is at its root a
xml config file
Review Comment:
Moved into it's own PR>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
