serhiy-bzhezytskyy commented on PR #4761: URL: https://github.com/apache/solr/pull/4761#issuecomment-5346813765
@dsmiley this removes three things you deprecated (`NamedList.get(String,int)`, `asShallowMap()`, `SolrParams.toNamedList()`). Worth your eyes specifically: `asShallowMap()` turned out to be a hybrid, not a plain view -- `get`/`put`/`remove` were live against the backing list but `entrySet()`/`keySet()`/`values()` returned copies. You know this class best, so a review here would help more than most. AI-assisted (Claude Sonnet 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
