serhiy-bzhezytskyy commented on code in PR #4761:
URL: https://github.com/apache/solr/pull/4761#discussion_r3838129869
##########
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java:
##########
@@ -1237,10 +1237,13 @@ protected void mergeIds(ResponseBuilder rb,
ShardRequest sreq) {
populateNextCursorMarkFromMergedShards(rb);
if (thereArePartialResults) {
- rb.rsp
- .getResponseHeader()
- .asShallowMap()
- .put(SolrQueryResponse.RESPONSE_HEADER_PARTIAL_RESULTS_KEY,
Boolean.TRUE);
+ NamedList<Object> header = rb.rsp.getResponseHeader();
Review Comment:
Replaced with `((SimpleOrderedMap<Object>)
rb.rsp.getResponseHeader()).put(...)`. `getResponseHeader()` is always a
`SimpleOrderedMap` at runtime, and its `put()` already does
indexOf+setVal-or-add in one call, so this collapses to a single statement
without reordering the entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
