adityamparikh commented on PR #157: URL: https://github.com/apache/solr-mcp/pull/157#issuecomment-5347289560
@epugh — following up on my review with a concrete PR rather than more prose: epugh/solr-mcp#1 against `add_release_steps`. It is deliberately three small edits, not a rewrite, since you said you want to keep this short: 1. **Adds the source-release step.** `./gradlew clean build` emits jars only — there is no source-archive task in `build.gradle.kts` — so the steps as written would produce a binary-only release. Added an explicit `git archive` from the commit being voted on; I ran it and it yields a 203-entry tarball of tracked files only. 2. **Scopes the signing/checksum loops.** `withSourcesJar()` + `withJavadocJar()` mean `build/libs` holds four jars, so `for fn in *.jar` signs all of them. Now copies the two released artifacts to `build/release` and works there — which also pins down the working directory the `../../gpgsign.sh` path was silently assuming. 3. **`sha512` → `shasum -a 512`**, which exists on both macOS and Linux, so the per-OS caveat goes away. Verified with `shasum -a 512 -c`. I deliberately left the vote mechanics, ATR background and verification steps that @janhoy asked for alone — those are policy and yours to write. This only covers the mechanical parts I could check against the repo. Also worth noting for sequencing: I've opened #181 with a verified merge order for the rebased PR queue, and it flags that #136 is the `-SNAPSHOT` step referenced here and needs retargeting to `branch_1_0_0` as you called out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
