serhiy-bzhezytskyy commented on code in PR #4758:
URL: https://github.com/apache/solr/pull/4758#discussion_r3828498627
##########
solr/core/src/java/org/apache/solr/schema/DatePointField.java:
##########
@@ -98,7 +98,8 @@
*
* @see PointField
*/
-public class DatePointField extends PointField implements DateValueFieldType {
+public class DatePointField extends PointField
Review Comment:
Yes, deliberately -- `instanceof` means subclasses inherit trust (old
`KNOWN_TYPES` used exact-class equality). `UUIDField extends StrField` without
overriding `toObject`, so it still returns a `String` -- safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
